fix: 28187 Include checkVisibility browser API as a reliable tool to check visibility #29741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
senpl
changed the title
…//github.com/senpl/cypress into issue-28187-IncludeCheckVisibilityBrowserAPI
jennifer-shehane
requested changes
Jun 25, 2024
There was a problem hiding this comment.
@senpl There are some failures in the assertions spec in CI for this change.
…//github.com/senpl/cypress into issue-28187-IncludeCheckVisibilityBrowserAPI
|
This related to visibility fixed. |
|
@senpl All of the tests will need to be passing in order for us to merge, with no breaking changes to users. |
|
We've decided to prioritize looking into these visibility fixes in Quarter 4 of this year, when we intend to spend time on Cypress 14 release. It will ease any concerns we have around releasing breaking changes with these fixes and also help us plan the proper time to review these. Tracking here: #29925 |
|
Updated the base branch to go against release/14.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visibility check in browser is close to one used in cypress. Still some test has to be changed to make it compatible with what is really seen in browser.
If backward compatibility is required then some option could be applied to make elements previously invisible still detected as invisible. Still default should be compatible with browser implementation.
Include
checkVisibilitybrowser API as a reliable tool to check visibility #28187Additional details
It should close many other visibility issues,
Steps to test
//this now should work
cy.get('details')
.children('div')
.should('not.be.visible')
How has the user experience changed?
Users should now use is hidden not is visible. Because some element might be visible still not really clicable or interactable.
In old version that two was connected. But hidden is not the same as visible. So this change make it compatible with other frameworks implementation.
PR Tasks
cypress-documentation?type definitions?